Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards better inference: bits → nibbles #3808

Open
wants to merge 234 commits into
base: main
Choose a base branch
from
Open

Conversation

originalsouth
Copy link
Contributor

@originalsouth originalsouth commented Nov 6, 2024

Changes

Bits → Nibbles

Issue link

N/A

Demo

T.B.D.

QA notes

Test all ported bits/new nibbles from front-end:

  • disallowed_csp_hostnames (with/without config)
  • check_cve_2021_41773
  • domain_owner_verification
  • expiring_certificate
  • ask_url_params_to_ignore
  • website_discovery
  • missing_certificate
  • cipher_classification
  • default_findingtype_risk
  • spf_discovery
  • max_url_length_config (with config for testing only)
  • oois_in_headers (with/without config)
  • ask_port_specification
  • ask_disallowed_domains
  • check_hsts_header (with/without config)
  • url_classification
  • missing_spf

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

originalsouth and others added 30 commits August 27, 2024 09:31
…uler from recreating already deleted oois trhough affirmations
…cheduler_from_reacreating_already_deleted_oois_through_affirmations' into feature/nibbles
@underdarknl underdarknl added this to the OpenKAT v1.19 milestone Jan 27, 2025
@Donnype Donnype removed their assignment Jan 29, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
38.5% Coverage on New Code (required ≥ 80%)
11.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bits nibbles Everything nibble related octopoes Issues related to octopoes
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

8 participants