Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_scan_level to nibbles with phantom result toggle #4054

Draft
wants to merge 3 commits into
base: feature/nibbles
Choose a base branch
from

Conversation

originalsouth
Copy link
Contributor

Add min_scan_level to nibbles with phantom result toggle

@originalsouth originalsouth added the nibbles Everything nibble related label Jan 29, 2025
@underdarknl
Copy link
Contributor

underdarknl commented Feb 4, 2025

Im curious as to why this phantom result is needed, what does it store, and why?

@noamblitz
Copy link
Contributor

@underdarknl its an interesting idea. Its because we do have to query to know which objects are relevant for the nibble. But after changing the scan level, there is no change in data so saving the phantom results in the first run saves a query when changing the scan level. If the scan level is high enough now, we can just write the phantom results without having to do any querying or calculation.

@noamblitz
Copy link
Contributor

I will add this to the docs including thought process as soon as I’m back.

Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
22.2% Coverage on New Code (required ≥ 80%)
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nibbles Everything nibble related
Projects
Status: To be discussed
Development

Successfully merging this pull request may close these issues.

3 participants