Make it possible to use SSL with PostgreSQL without client certificate #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Lgtm |
ammar92
approved these changes
Feb 5, 2025
| POSTGRES_SSL_CERT = env.path("POSTGRES_SSL_CERT", default="") | ||
| POSTGRES_SSL_KEY = env.path("POSTGRES_SSL_KEY", default="") | ||
|
|
||
| if POSTGRES_SSL_CERT and POSTGRES_SSL_KEY: |
There was a problem hiding this comment.
Would it make sense to also set "sslmode" to "require" here when these options are configured?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The rocky settings required providing a client certificate when you use SSL to connect to PostgreSQL, but it is also possible to connect using SSL without a client certificate.
QA notes
Please add some information for QA on how to test the newly created code.
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.