Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create services only if dependency is available #169

Merged
merged 4 commits into from
Oct 3, 2018

Conversation

ossinkine
Copy link
Contributor

Closes #149 #168

@kmarques
Copy link

Any news about this PR?

I'm using this great bundle within my project. The point is that i'm using api-platform/api-platform and i don't need the templating engine.

@ossinkine
Copy link
Contributor Author

@rh389 It seems you have no time to maintain this project. Maybe can you trust someone to maintain it?

@robhogan
Copy link
Member

robhogan commented Oct 2, 2018

Thanks @ossinkine, and sorry for the delay.

I'd be in favour of bringing more people into this project but it's not really my call - ping @thewilkybarkid ;)

@ossinkine
Copy link
Contributor Author

@thewilkybarkid A lot of people using this project but unfortunately it is not maintaned properly. Could you entrust the maintaining of the project to a wider range of people?

@robhogan
Copy link
Member

robhogan commented Oct 3, 2018

LGTM, thanks

@robhogan robhogan merged commit 8c04422 into misd-service-development:master Oct 3, 2018
@teohhanhui
Copy link

teohhanhui commented Jul 11, 2019

This was merged into master. (Why? It's a bug fix.)

And there hasn't been a 2.0 release. So this is still not fixed as far as the users are concerned... 😞

@ossinkine
Copy link
Contributor Author

@teohhanhui Why is this a bug?

@teohhanhui
Copy link

teohhanhui commented Jul 12, 2019

@ossinkine Because v1.3 of the bundle breaks when symfony/templating is not installed, for example. And that's very much possible (and expected) beacuse symfony/templating is not in require.

Sorry, I meant to say it's a bug fix. Perhaps that was confusing...

@MlleDelphine
Copy link

@thewilkybarkid and @rh389

Please, any action from your side to apply this PR to branch 1.3 please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symfony Flex compatibility
6 participants