phone number format as option instead of hard set to NATIONAL #173
Conversation
…or like single_text widget)
|
Resolves #171 |
|
Hi, the travis configuration seems broken |
|
Thanks for the PR. Travis seems to be fine, but this change is causing tests to fail because you’ve changed the default format to |
|
Ok thanks @rh389 I'm updating the test case. |
|
@rh389 tests passed =). |
| public function __construct(array $countryChoices) | ||
| public function __construct( | ||
| array $countryChoices, | ||
| $format = PhoneNumberFormat::INTERNATIONAL |
There was a problem hiding this comment.
Sorry, I wasn't clear before. The test cases were fine, they highlighted a breaking change. The problem is this line - the default option should be NATIONAL because that's what it was fixed to before.
Anything else is going to result in a change in behaviour for peoples' existing setups.
There was a problem hiding this comment.
Ok i revert test changes and set default format to national, thank you @rh389
There was a problem hiding this comment.
If you could add a few more tests to those cases to check the desired result with a couple of different formats, that'd be perfect. Thanks again!
|
@rh389 default format set to NATIONAL |
|
hi @rh389 , do you validate the tests ? |
|
@rh389 ping |
behavior like single_text widget)