Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination links breaks when paginated with search params in Rails 5 #486

Closed
rahulvn opened this issue Jun 8, 2016 · 7 comments
Closed

Comments

@rahulvn
Copy link

rahulvn commented Jun 8, 2016

I was working on ruby 2.3.0 - rails 5.0.0.rc1 - will_paginate 3.1.

Pagination link breaks when there is a search param in the URL.

@jesseiqmi
Copy link

@rahulvn Same thing here - found the following to address this https://github.com/jonatack/will_paginate

Giving it a try now myself to see if this works until this can be addressed here.

@jesseiqmi
Copy link

@rahulvn nix that. I got a whole bunch of other errors.

Did you find a way through this yourself? Here's another ticket from Ransack that looks familiar as well: activerecord-hackery/ransack#687

@rahulvn
Copy link
Author

rahulvn commented Jun 30, 2016

@jesseiqmi I have fixed it with this patch: #483

@jesseiqmi
Copy link

@rahulvn thanks - I did the same thing with an earlier PR found at e11cae7 (less overall changes to solve my immediate issue).

Cheers

@rahulvn
Copy link
Author

rahulvn commented Jun 30, 2016

Great 👍

@jonatack
Copy link
Contributor

jonatack commented Jul 13, 2016

Ransack master has been working with Rails 5 since a year and a half now:

gem 'ransack', github: 'activerecord-hackery/ransack'

Will cut a new official Ransack release very soon, but Ransack master is available.

P.S. as mentioned near the top of the Ransack README, if you are using will_paginate with Rails 5, for now you'll need to use my version at https://github.com/jonatack/will_paginate:

gem 'will_paginate', github: 'jonatack/will_paginate'

@jonatack
Copy link
Contributor

Apologies, posted in the wrong page 😄. Cheers.

@mislav mislav closed this as completed in 89c8b6c Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants