Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails5 compatibility #483

Closed
wants to merge 3 commits into from
Closed

Conversation

olegantonyan
Copy link

@olegantonyan olegantonyan commented Apr 26, 2016

Same idea as here #469 but this one doesn't brake old versions with undefined constant.

I have troubles with travis. There couple of failures with some ruby versions, similar to this one rubygems/bundler#2780 I have no idea what's wrong, but I'm sure it's not related to this change

@nmeylan
Copy link

nmeylan commented Jul 1, 2016

Hello,
Can we have any news on when this PR will be merged?
Rails 5 is out now, and it seems this issue is the only one that broke Rails 5 compatibility

Kind regards

@codeodor
Copy link

codeodor commented Jul 7, 2016

You all might try value = value.to_h if !value.is_a?(Array) && value.respond_to?(:to_h) to make it a simpler and more resilient change.

@mislav
Copy link
Owner

mislav commented Sep 21, 2016

@nmeylan Sorry for the late reply. I will try to take care of this as soon as possible.

@mislav mislav closed this in 89c8b6c Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants