Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(dev): non-production環境でhttpサーバー間でもユーザー、ノートの連合が可能なように #10717

Merged
merged 6 commits into from
Apr 29, 2023
Merged

enhance(dev): non-production環境でhttpサーバー間でもユーザー、ノートの連合が可能なように #10717

merged 6 commits into from
Apr 29, 2023
+32 −13

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Apr 25, 2023 •
edited
Loading

Resolve #10716

What

  • ユーザーのhostにポートが含まれていなかったのを修正
  • ユーザー、ノートをproductionでない環境ではhttpも許可
  • MISSKEY_WEBFINGER_USE_HTTPでtrueを指定するとWebFingerをhttpで行うように

Why

Resolve #10716

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 25, 2023
@github-actions github-actions bot requested a review from rinsuki April 25, 2023 15:46
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #10717 (a75350d) into develop (2aa75f5) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff            @@
##           develop   #10717   +/-   ##
========================================
  Coverage    76.07%   76.08%           
========================================
  Files          898      899    +1     
  Lines        88718    88756   +38     
  Branches      6262     6270    +8     
========================================
+ Hits         67494    67529   +35     
- Misses       21224    21227    +3
Impacted Files Coverage Δ
packages/backend/src/core/WebfingerService.ts 63.46% <0.00%> (-1.25%) ⬇️
...kend/src/core/activitypub/models/ApImageService.ts 48.97% <33.33%> (+0.52%) ⬆️
...end/src/core/activitypub/models/ApPersonService.ts 63.53% <73.33%> (+0.41%) ⬆️
packages/backend/src/misc/check-https.ts 75.00% <75.00%> (ø)
...ckend/src/core/activitypub/models/ApNoteService.ts 55.77% <100.00%> (+0.11%) ⬆️

... and 4 files with indirect coverage changes

@tamaina tamaina mentioned this pull request Apr 25, 2023
Merged
11 tasks
@tamaina
Copy link
Contributor Author

tamaina commented Apr 26, 2023 •
edited
Loading

  • ヘルパー関数を使うようにリファクタ
  • WebFingerをhttpで行うようにするにはMISSKEY_WEBFINGER_USE_HTTPでtrueを指定するように

@tamaina tamaina merged commit 09764b9 into misskey-dev:develop Apr 29, 2023
sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
@tamaina @sasagar
enhance(dev): non-production環境でhttpサーバー間でもユーザー、ノートの連合が可能なように (misskey…
60c6588 
…-dev#10717)

* enhance(dev): non-production環境でhttpサーバー間でもユーザー、ノートの連合が可能なように

* refactor (use checkHttps)

* MISSKEY_WEBFINGER_USE_HTTP

* Environment Variable readme

* NEVER USE IN PRODUCTION

* fix punyHost
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
@tamaina @na2na-p
enhance(dev): non-production環境でhttpサーバー間でもユーザー、ノートの連合が可能なように (misskey…
462a593 
…-dev#10717)

* enhance(dev): non-production環境でhttpサーバー間でもユーザー、ノートの連合が可能なように

* refactor (use checkHttps)

* MISSKEY_WEBFINGER_USE_HTTP

* Environment Variable readme

* NEVER USE IN PRODUCTION

* fix punyHost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinsuki rinsuki rinsuki left review comments

@saschanaz saschanaz saschanaz left review comments

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
3 participants
@tamaina @saschanaz @rinsuki