Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): Remove an unnecessary type assertion #12666

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Dec 14, 2023

What

要らなくなったType Assertionを削除します。

Why

delvedor/find-my-way#324 にて修正されたようです。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 14, 2023
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4178527) 79.67% compared to head (0726b48) 79.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12666      +/-   ##
===========================================
- Coverage    79.67%   79.63%   -0.05%     
===========================================
  Files          959      957       -2     
  Lines       108481   108290     -191     
  Branches      8346     8345       -1     
===========================================
- Hits         86437    86241     -196     
- Misses       22044    22049       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 5cc3d3c into misskey-dev:develop Dec 15, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 15, 2023

🙏

@woxtu woxtu deleted the patch branch December 15, 2023 12:57
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants