refactor(misskey-js): 警告をすべて解決 #14257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14257 +/- ##
===========================================
- Coverage 42.07% 42.00% -0.07%
===========================================
Files 1527 1527
Lines 195068 195074 +6
Branches 2688 3576 +888
===========================================
- Hits 82079 81948 -131
- Misses 112448 112555 +107
- Partials 541 571 +30 ☔ View full report in Codecov by Sentry. |
… after the check)
|
|
| @@ -14,6 +14,7 @@ export type APIError = { | |||
| code: string; | |||
| message: string; | |||
| kind: 'client' | 'server'; | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
潰すと多分広範囲に影響するので後のPRでやる
| @@ -29,6 +30,7 @@ export type FetchLike = (input: string, init?: { | |||
| headers: { [key in string]: string } | |||
| }) => Promise<{ | |||
| status: number; | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| @@ -49,6 +51,7 @@ export class APIClient { | |||
| this.fetch = opts.fetch ?? ((...args) => fetch(...args)); | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
KisaragiEffective
changed the title
|
ready for review |
…reverted after the check)" This reverts commit 67072e3.
🎉 |
tai-cha
reviewed
Jul 18, 2024
Comment on lines
+7
to
8
| // eslint-disable-next-line no-param-reassign | ||
| if (acct.startsWith('@')) acct = acct.substring(1); |
There was a problem hiding this comment.
これは素直にコメントで抑制するのではなく引数に上書きせずに再宣言した方がいいタイプな気がする
There was a problem hiding this comment.
どうだろう...Strict modeだと arguments との影響もないしあるし正直私はno-param-reassign自体の有用性に疑問を持ってます...
There was a problem hiding this comment.
既存の振る舞いを壊さないようにASTを変えない範囲で解決したので、別のPRに分けたい気持ちがややある
やるか |
|
やった |
|
あれこれcloseされたのなぜかしら |
10 tasks
|
復旧しました: #14277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
close #14253
Why
issueに記載のため省略
Additional info (optional)
オセロゲームのeslint-disable-next-line @typescript-eslint/no-explicit-anyはフロントエンドの解析が必要なのでこのPRでは取り組まないChecklist