Showing Course rather than Courses (or program/s) when there is only 1 to display #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinpreston
approved these changes
Mar 25, 2024
| @@ -561,6 +561,20 @@ export class CatalogPage extends React.Component<Props> { | |||
| } else return 0 | |||
| } | |||
|
|
|||
| renderCatalogCount() { | |||
There was a problem hiding this comment.
I would just add a description above this method describing what it does.
| @@ -882,4 +882,36 @@ describe("CatalogPage", function() { | |||
| JSON.stringify([displayedProgram, newProgram]) | |||
| ) | |||
| }) | |||
|
|
|||
| it("renderCatalogCount is plural for more than one course", async () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/2488
Description (What does it do?)
Adds a function to render the correct display text on the desktop view for 1 course or program as opposed to multiple (without an s to make the noun plural).
How can this be tested?
Create a department that only has one course and/or one program assigned. You should see the text change from 1 courses (in current main branch) to 1 course when you select that department on the catalog page.