This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
optimization: only sort top N items when numResultsShown option is passed #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting a large array is quite expensive, >500ms for ~50,000 strings. Usually the UI only displays ~100 or so items. The optimization switches to bubble sort and only sorts top N items if N is much smaller than total number of results.
This ensures that pressing the first key stroke e.g 'a' can have its results computed in <50ms. Previously this needed a debounce due to large sorting overhead. Now we react on every keystroke and UI feels very responsive.