Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused functions and rewrote others using modern browser capabilities #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabiomcosta
Copy link
Contributor

@fabiomcosta fabiomcosta commented Sep 21, 2017

mixpanel-js is big.

The approach I'm taking here is to use modern browsers capabilities to decrease the code size, but a bigger win might come from splitting the lib up into other smaller libs that each can attend a specific use case/feature.
Ex: one for notifications, another for user tracking, etc.

This discussion started at #128

Numbers:
mixpanel.min.js: 59.4K -> 52K (-7.4K, 13.5% reduction) (non-gzipped)

Please let me know if there is more unused code or if there is anything else I can improve further.

@fabiomcosta
Copy link
Contributor Author

fabiomcosta commented Sep 27, 2017

@jbwyme any change this will could be merged? I just wanted to start a conversation.
What are the browsers this library has to support?

@ghost
Copy link

ghost commented Oct 6, 2017

@tdumitrescu @jbwyme any update on this?

@hackuun
Copy link

hackuun commented Feb 4, 2018

+1 any news?

@fabiomcosta
Copy link
Contributor Author

Let me know if you're moving forward with this, I can solve conflicts to get it merged, but since I didn't get an answer from the beginning I'm not going to do these changes now before I get a clear confirmation.

1 similar comment
@fabiomcosta
Copy link
Contributor Author

Let me know if you're moving forward with this, I can solve conflicts to get it merged, but since I didn't get an answer from the beginning I'm not going to do these changes now before I get a clear confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants