-
Notifications
You must be signed in to change notification settings - Fork 53
Fixed showing content in single line in WP 6.5 #138
Conversation
I can confirm that this is the right fix. This block should copy the core save function. |
Ideally, modifications to this block should be done with block filters, or by creating a separate block, so changes to this save function don't need to be copied over all the time. I see that this save function also doesn't escape short codes and embeddable URLs. |
Is it for https://github.com/mkaz/code-syntax-block/issues/139 issue? |
Please, can you explain (or attach some link) how to build source of this plugin before installing to WP? |
+1 |
Highly recommending to merge this branch. |
@muditbac Thank you But how did you build it?
Or something else? |
Yes, built using npm commands you mentioned. But was not sure on how to generate zip, thus downloaded existing zips and replaced few js files with built files. I know it is hacky, didn't have any other option. |
Read the "justfile" |
@mkaz @westonruter @memuller @jazanne @jeherve @ethanclevenger91 🙏 please include this fix for WP 6.5 users, we need this ASAP. Thank you. |
Merged. Now let's see if I remember how to release 😅 |
Thanks @chandan-tudu, I haven't really been monitoring this repo too much, so I didn't realize it was broken with WP 6.5. All fixed and released in v3.2.0 in WP plugin repo now. (Thank god for automation, release was easy) |
@mkaz thank you! Working now on WP 6.5 💪 |
In WP 6.5, content is appearing in a single line because
<br>
is being used in place of\n
.