Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen resizing after initial launch #5

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

gardenappl
Copy link
Contributor

My program, svitlyna, resizes its screen to fit the image that it's displaying - the resizing happens after the reset vector because the program relies on Console/vector to get the image data.

This emulator has code for handling this scenario but it didn't seem to get triggered for whatever reason, so I re-wrote it slightly, and now it works.


The other issue is that, for whatever reason, the resizing doesn't always work on Wayland. I tried updating the egui dependency to include this fix, but it didn't seem to work either. However, the new versions require you to specify build features for Wayland and/or X11, and I was able to fix it by adding the x11 feature but not the wayland feature. But I don't think that's a good solution, so I'm not submitting it.

I could try to investigate it further but I am a complete beginner in Rust, in fact these two PRs are my very first lines of Rust code.

@mkeeter mkeeter merged commit 196e531 into mkeeter:main Jan 18, 2025
@mkeeter
Copy link
Owner

mkeeter commented Jan 18, 2025

Thanks, merged (although see #6 for some follow-up cleanups)

I'm a complete beginner with Wayland (and don't have any systems to test on), so am happy to defer updating the egui dependency until someone else wants to drive it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants