Fix screen resizing after initial launch #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My program, svitlyna, resizes its screen to fit the image that it's displaying - the resizing happens after the reset vector because the program relies on
Console/vector
to get the image data.This emulator has code for handling this scenario but it didn't seem to get triggered for whatever reason, so I re-wrote it slightly, and now it works.
The other issue is that, for whatever reason, the resizing doesn't always work on Wayland. I tried updating the
egui
dependency to include this fix, but it didn't seem to work either. However, the new versions require you to specify build features for Wayland and/or X11, and I was able to fix it by adding thex11
feature but not thewayland
feature. But I don't think that's a good solution, so I'm not submitting it.I could try to investigate it further but I am a complete beginner in Rust, in fact these two PRs are my very first lines of Rust code.