Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

How to separate p5 from non-p5 examples? #1

Closed
dariusk opened this issue Mar 6, 2018 · 6 comments
Closed

How to separate p5 from non-p5 examples? #1

dariusk opened this issue Mar 6, 2018 · 6 comments

Comments

@dariusk
Copy link

dariusk commented Mar 6, 2018

Should we create a directory structure like this?

examples-p5/
examples-js/

I'm actually at a loss for what to call the "plain JavaScript" examples. Plain? Vanilla? ES2017? JavaScript? The problem of course being that p5 is also JavaScript.

@shiffman
Copy link
Member

shiffman commented Mar 6, 2018

Dare we say:

examples/
examples-p5/

Another option is rather than have two versions of examples just have some depend on p5 and some not and be clear about that in documentation.

Some other ideas:

examples-js/
examples-p5-which-is-also-js-it-is-a-js-library/
examples-sans-p5
examples-p5

@cvalenzuela
Copy link
Member

Since the repo is already called ml5-examples, what about having something like this:

javascript/
p5js/

And then we could have ML5 examples with other frameworks too:

javascript/
p5/
three/
rita/
pixi/
etc..

maybe its too much?

cvalenzuela added a commit that referenced this issue Mar 10, 2018
…0.5.

It also introduces some changes to a couple of the examples to better handle images and text with p5.
The Neural Network example has been removed until the method is ready on the library.

The stucture of the folders also has changes, reflecting #1
@handav
Copy link
Member

handav commented Mar 19, 2018

Going through this for the first time, I think having the folder be called p5js is confusing. I like Darius and Dan's idea of having 'examples' in the folder names as well.

I don't think it's a bad idea to separate out the examples by framework/language, though.

@cvalenzuela
Copy link
Member

Closing this because it seems resolved. We decided to go with this for now:

javascript/
p5/
three/
rita/
pixi/
etc..

@shiffman
Copy link
Member

shiffman commented Jun 5, 2018

Love it! Looking forward to three.js examples! Say hi to @mrdoob at Eyeo this week! (Was such an honor to meet IRL!)

@mrdoob
Copy link

mrdoob commented Jun 5, 2018

@shiffman same! 😊

AidanNelson pushed a commit to AidanNelson/ml5-examples that referenced this issue Oct 17, 2018
…0.5.

It also introduces some changes to a couple of the examples to better handle images and text with p5.
The Neural Network example has been removed until the method is ready on the library.

The stucture of the folders also has changes, reflecting ml5js#1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants