Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Object detector examples update #255

Merged
merged 5 commits into from
Dec 12, 2019

Conversation

tirtawr
Copy link
Contributor

@tirtawr tirtawr commented Dec 8, 2019

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Which branch are you submitting to? 🌲

Release

β†’ Step 2: Describe your Pull Request πŸ“

Updated some examples for object detector

A great PR 🌟🌟

β†’ Step 3: Share a Relevant Example πŸ¦„

Here's some example code or a link to another PR in https://github.com/ml5js/ml5-examples OR in the https://editor.p5js.org or codepen/jsfiddle/etc...

The best PR 🌟🌟🌟

β†’ Step 4: Screenshots or Relevant Documentation πŸ–Ό

Here's some helpful screenshots and/or documentation of the new feature

Copy link

@loaiabdalslam loaiabdalslam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Make a small description about your steps why we changed all files meta links to
localhost:8080/ml5

@shiffman
Copy link
Member

shiffman commented Dec 9, 2019

Woohoo, excited about this, thank you @tirtawr! I think this pull request needs to be made to development rather than release!

@tirtawr tirtawr changed the base branch from release to development December 9, 2019 20:00
@tirtawr
Copy link
Contributor Author

tirtawr commented Dec 9, 2019

@shiffman oops, my bad. I've updated the target branch.

@loaiabdalslam Hmm, yeah I'm not sure about this. I was just following the examples that were already there πŸ˜…. Maybe @joeyklee knows more about this? It might be because currently for these specific examples we're using an unreleased version of ml5 that's still in the development branch.

@shiffman
Copy link
Member

shiffman commented Dec 9, 2019

@tirtawr that's correct! In the development branch, the ml5 library points to a locally built file (which assumes you are building your own dev version of the library), the release examples point to the actual release! @loaiabdalslam

@joeyklee joeyklee merged commit 720fd29 into ml5js:development Dec 12, 2019
@joeyklee
Copy link
Contributor

Many thanks @tirtawr ! Merged! πŸ™

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants