Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

added interactive regression example #257

Closed
wants to merge 1 commit into from
Closed

added interactive regression example #257

wants to merge 1 commit into from

Conversation

LudwigStumpp
Copy link

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

β†’ Step 1: Which branch are you submitting to? 🌲

development to add an example for Regression.

β†’ Step 2: Describe your Pull Request πŸ“

I am submitting a new interactive example for Regression using the NeuralNetwork class.

Previously there were some problems with it, described at ml5js/ml5-library#721. Basically, the issue was that not all data points were taken into account (since the validationSplit parameter of the NeuralNetwork training option was permanently set to 0.1).

But since this issue is now closed and changes were merged to the development branch (see ml5js/ml5-library@f749d4e; src/NeuralNetwork/NeuralNetwork.js; line 108) the example now works as expected.

The idea behind this example is that one can add multiple data points to use regression to fit a line. The already present example of NeuralNetwork_Simple_Regression does not have the feature to add points interactively + to change some core model parameters. This is why I wanted to share this example.

One can add data points and modify:

  • learningRate
  • hiddenUnits
  • batchSize
  • epochs

and see the changes.

I would not be upset if you decide not to add this example, since it might be a little bit redundant compared to NeuralNetwork_Simple_Regression.

β†’ Step 4: Screenshots or Relevant Documentation πŸ–Ό

Here's some helpful screenshots and/or documentation of the new feature

image

@joeyklee
Copy link
Contributor

@LudwigStumpp - Apologies for the super late reply here! Wow this example is awesome and very cool to be able to use these inputs!

@shiffman @bomanimc - I've been thinking maybe there's a separate spot on our website we might be able to highlight these kinds of projects that are slightly more advanced but still very helpful references for teaching? Feels like it might also be a consideration for the the upcoming work of @AndreasRef ?

@shiffman
Copy link
Member

shiffman commented Mar 4, 2020

@joeyklee yes, I agree! Thanks for this wonderful contributions @LudwigStumpp! I never loved the term "demos" but something along that line could make sense?

@LudwigStumpp
Copy link
Author

@joeyklee @shiffman thank you! The term "demo" does indeed make sense in my opinion.

@joeyklee
Copy link
Contributor

joeyklee commented Mar 4, 2020

Looping in @bomanimc into this thread as I think this also relates to the work thinking about future devOps processes and where we might include / separate out "demos" vs. "examples".

Also related to Andreas Refsgaard and Emily's Fellowship!

@bomanimc
Copy link
Member

I think that having a demos section makes sense as well! I'd be happy to help with adding some changes to the ml5 examples index site to make those changes apparent.

It may make sense to merge these changes in as examples for now, and then move them into a demo section later. We'll likely be archiving this repository soon as a part of the changes we're making to ml5js/ml5-library#831. If that happens before these changes are merge, please feel free to reopen on https://github.com/ml5js/ml5-library!

@bomanimc
Copy link
Member

Hey @LudwigStumpp! We're archiving this repository and moving its contents into the core ml5-library repository (more context on issue #809 and pull request #831). We appreciate your contributions and would love it if you'd consider reopening this pull request on the ml5-library repo! Thanks!

@LudwigStumpp
Copy link
Author

Done. This can be closed now, I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants