Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features] Update tensorflowjs dependency #690

Closed
WenheLI opened this issue Nov 8, 2019 · 4 comments
Closed

[Features] Update tensorflowjs dependency #690

WenheLI opened this issue Nov 8, 2019 · 4 comments
Labels

Comments

@WenheLI
Copy link
Member

WenheLI commented Nov 8, 2019

As the latest tensorflowjs provide webworker support, it makes the inference less likely to block the UI rendering (in another world, it will be less likely to freeze the UI).
Here is a post that describes the webworker in tensorflowjs.
I think we should upgrade the tensorflowjs so that our ml5 could have such support too.
I can also write a quick tutorial for webworker in ml5 after the upgrade.

@joeyklee
Copy link
Contributor

joeyklee commented Nov 8, 2019

@WenheLI - This is definitely on our list, however since we have tfjs dependencies that vary across the different models we support, we should try to stay in-sync with those if possible. As you've pointed out, there's a lot of exciting updates from the tfjs side so we should definitely try to bump the version up when we can!

@bomanimc
Copy link
Member

I think we were able to accomplish this in #846, though there's still work to be done around updating all of our other models to their latest versions.

@WenheLI would you still be interested in the webworker changes?

@WenheLI
Copy link
Member Author

WenheLI commented Apr 20, 2020

@bomanimc - Sure! I can add some examples of how to combine webworker with ml5!

@bomanimc
Copy link
Member

Closing this issue out after the update in #846. @WenheLI please feel free to make a separate issue for the web worker changes if you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants