Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @tensorflow/tfjs to 1.7.0 #846

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

bomanimc
Copy link
Member

This PR updates tfjs to the most recent minor version (1.7.0, though the patch 1.7.1 is out but not yet supported by FaceAPI). In addition, I needed to:

This will allow us to update the versions of some of our other models, but I'll save those changes for later PRs.

Updated Build Sizes

Built at: 3/31/2020 1:26:48 AM
         Asset      Size  Chunks                    Chunk Names
    ml5.min.js  2.35 MiB    0, 1  [emitted]  [big]  ml5.min
        ml5.js  4.91 MiB    1, 0  [emitted]  [big]  ml5
ml5.min.js.map  7.37 MiB    0, 1  [emitted]         ml5.min
    ml5.js.map  5.79 MiB    1, 0  [emitted]         ml5

It looks like this caused some changes in build size. Comparison to current sizes in 0.5.0 (https://unpkg.com/browse/[email protected]/dist/)
ml5.min.js -> 2.67 MB
ml5.js -> 5.6 MB
ml5.min.js.map -> 8.45 MB
ml5.js.map -> 6.62 MB

This cuts our minified distribution down by 0.32MB!

Testing Process

  • Ran yarn test-travis and saw no errors
  • Manually test the CharRNN and FaceApi examples to ensure they were still functioning.

Copy link
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Great to see that these changes have fixed some issues and also reduced the size of the lib. Thank you for addressing this!

@joeyklee
Copy link
Contributor

Merging in now!

@joeyklee joeyklee merged commit ad5bb1c into development Mar 31, 2020
@joeyklee joeyklee deleted the bomani.update-tfjs-version branch March 31, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants