Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead link to TM #1154

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Dead link to TM #1154

merged 1 commit into from
Mar 7, 2021

Conversation

tlsaeger
Copy link
Member

@tlsaeger tlsaeger commented Mar 4, 2021

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

→ Step 1: Describe your Pull Request 📝

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?
Hey Guys,
I just found a dead link to teachable machine. It seemed to link to a specific page, which was removed. It could be linking to https://teachablemachine.withgoogle.com/train/audio instead of my proposal of the main page. But going to the homepage would give new users a better understanding where they are, I think!?

What do you think and if it?

A great PR 🌟🌟

→ Step 2: Share a Relevant Example 🦄

Here's some example code or a demonstration of my feature as a part of this pull request, a separate pull request, in the https://editor.p5js.org, or codepen/jsfiddle/etc...

The best PR 🌟🌟🌟

→ Step 3: Screenshots or Relevant Documentation 🖼

Here's some helpful screenshots and/or documentation of the new feature

@tlsaeger
Dead link to TM
bcef371 
Hey Guys, 
I'm not quite sure if it works if i file a PR like this, I just found a dead link to teachable machine. It seemed to link to a specific page, which was removed. It could be linking to https://teachablemachine.withgoogle.com/train/audio instead of my proposal of the main page. But going to the homepage would give new users a better understanding where they are, I think!? 
What do you think and if it is not possible to file this PR from here. I can do it the official way as well.
bomanimc
bomanimc approved these changes Mar 7, 2021
View reviewed changes
Copy link
Member

@bomanimc bomanimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you! Good catch!

@bomanimc bomanimc merged commit 7bca138 into ml5js:main Mar 7, 2021
@tlsaeger tlsaeger deleted the patch-1 branch March 7, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomanimc bomanimc bomanimc approved these changes

Assignees
No one assigned
Labels
ready for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlsaeger @bomanimc