Word2vec.nearestFromSet() is always null output

[Mudasar-Makandar]

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

Fixing a Bug
Word2vec.nearestFromSet() is giving always null output.

Reason:
!miniModel.length is always true because miniModel is object and it's length attribute is undefined.
Hence Word2vec.nearestFromSet() is always giving null output.

Changes:
Object.Keys(miniModel).length will give correct sense while checking for it's length.

[Mudasar-Makandar]

Thanks for the review.
I have resolved the typo.

[joeyklee]

Tagging in @bomanimc our ml5 lead here.
I've reviewed this PR and it looks like it shouldn't introduce any breaking changes (it actually should fulfill the expected behavior!). Since minModel is defined as an object and Object.keys(minModel) will always return an array [], the length property should always exist. And so if there are no elements in the array, then we can successfully null.

Nice one @Mudasar-Makandar !

[bomanimc]

LGTM

[joeyklee]

@all-contributors please add @Mudasar-Makandar for bug code

[allcontributors]

@joeyklee

I've put up a pull request to add @Mudasar-Makandar! 🎉

[joeyklee]

NOTE @Mudasar-Makandar -- because word2vec has been disabled in ml5, I wanted to merge this PR in anyways just to recognize your efforts. Even though your changes won't be in effect, I still wanted to make sure that you are shown as a contributor for this bug fix. Thanks so much and apologies that this fix did not make it in before word2vec was disabled in ml5.