Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled p5 web editor examples #1246

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

tlsaeger
Copy link
Member

@tlsaeger tlsaeger commented Nov 3, 2021

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

As mentioned in #1243 and discussed with @shiffman I temporarily disabled the links to the p5 web-editor examples.
I replaced it with the following comment:
Please be advised, that due to an incompatibility of the p5 web-editor and the weights that are used in this example, this example does not work in the p5 we-editor.
Please use the p5.js example locally. Learn more about how to run examples locally here.

@joeyklee joeyklee added the SEMVER/patch a version tag for a patch release change label Feb 8, 2022
Copy link
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY! LGTM 👍

@joeyklee joeyklee merged commit a409ffe into ml5js:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation SEMVER/patch a version tag for a patch release change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants