Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1265 Integrate release drafter for automating releases #1266

Merged
merged 7 commits into from
Jan 21, 2022

Conversation

joeyklee
Copy link
Contributor

@joeyklee joeyklee commented Jan 20, 2022

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Describe your Pull Request πŸ“

In this PR:

  • Adds a publish.yml file that uses github actions to publish to npm when we tag a new release
  • Adds the release -drafter.yaml to handle drafting releases and version tagging

Outside of the code:

  • I added our NPM_TOKEN to our github secrets to allow us to publish in an automated way

@joeyklee joeyklee added devops SEMVER/minor a version tag for a minor release change labels Jan 20, 2022
@joeyklee joeyklee requested review from shiffman and bomanimc January 21, 2022 00:00
@joeyklee
Copy link
Contributor Author

@shiffman and @bomanimc -- I'm not sure if this actually will work as I expect (first time trying this on my own) but I think it should? We might need to be flexible to experiment a bit if that's ok! Thanks!

@joeyklee joeyklee marked this pull request as ready for review January 21, 2022 00:02
@joeyklee joeyklee closed this Jan 21, 2022
@joeyklee joeyklee reopened this Jan 21, 2022
@joeyklee
Copy link
Contributor Author

I will merge this in and test to see if it works! πŸ™ˆ

@joeyklee joeyklee merged commit 9c2c74f into main Jan 21, 2022
@joeyklee joeyklee deleted the joeykee.1265-release-drafter branch January 21, 2022 00:29
@shiffman
Copy link
Member

Wow, amazing @joeyklee!!!!!

@bomanimc
Copy link
Member

Thanks for testing this out!

@joeyklee
Copy link
Contributor Author

NP! Sorry for all the noise! I hadn't thought through a good way to debug until much later πŸ™ˆ πŸ˜‚<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops SEMVER/minor a version tag for a minor release change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants