Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates docs with latest release process #1293

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

joeyklee
Copy link
Contributor

@joeyklee joeyklee commented Feb 3, 2022

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Describe your Pull Request πŸ“

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?

  • Adds the latest notes on how a ml5 maintainer can tag a release and publish to npm. This is now all done when you "tag a release" in the releases tab!

@joeyklee joeyklee added the SEMVER/patch a version tag for a patch release change label Feb 3, 2022
## Before tagging a release releasing: bump the package version
1. open a PR to bump the package version: e.g. `git checkout -b v0.8.12`
2. bump the package version number that matches the `SEMVER/patch | SEMVER/minor | SEMVER/major`
- e.g. `SEMVER/patch`: `0.8.11` would become -> `0.8.12`
Copy link
Member

@tlsaeger tlsaeger Feb 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (line 15 and following) might also be helpful in the new version. Which tag leads to which version number.

@tlsaeger
Copy link
Member

tlsaeger commented Feb 5, 2022

Hi @joeyklee thanks for taking the time. I think this is really great. I never did a release so I cannot really compare the two processes, but if I look at the docs it looks way easier.
On thing I liked in the old version is, that we specified which tag leads to which version number. I guess it would be good to have it implemented in the new version as well.

@tlsaeger
Copy link
Member

tlsaeger commented Feb 5, 2022

Just tried it by merging PR #1297 works perfectly well. πŸ₯³ Thanks @joeyklee

@joeyklee
Copy link
Contributor Author

Thanks for giving this one a try @tlsaeger ! Happy that it is working ok. I hope to refine some of this CI/CD work throughout the year, but for now, I'm glad this helps us out a little bit!

@joeyklee joeyklee merged commit b342408 into main Feb 23, 2022
@joeyklee joeyklee deleted the joeyklee.devops-updates-docs branch February 23, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SEMVER/patch a version tag for a patch release change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants