Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(#637): Migrate testing utilities to Jest - remove other testing libs pt.2/X #1295

Merged
merged 4 commits into from
Apr 5, 2022

Conversation

joeyklee
Copy link
Contributor

@joeyklee joeyklee commented Feb 3, 2022

For details -- see: #1294

@joeyklee joeyklee added the SEMVER/minor a version tag for a minor release change label Feb 3, 2022
@joeyklee joeyklee changed the title refactor(#637): WIP - Migrate testing utilities to Jest - remove other testing libs pt.2/X refactor(#637): Migrate testing utilities to Jest - remove other testing libs pt.2/X Feb 4, 2022
@joeyklee joeyklee requested review from bomanimc and shiffman February 4, 2022 01:57
@lindapaiste
Copy link
Contributor

If you don't want to rename test files you can change the testRegex setting instead so that it finds the current files. For example, _test\.js will match all index_test.js files.

Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay. excited to see this!

@joeyklee
Copy link
Contributor Author

joeyklee commented Mar 4, 2022

If you don't want to rename test files you can change the testRegex setting instead so that it finds the current files. For example, _test\.js will match all index_test.js files.

  • Hi! Oh yes this is a great suggestion. I was thinking that maybe adding the __tests__ directories and moving each of the test files into those dirs might be a nice way of accounting for the test updates? This way we can incrementally chip away at updating tests for each feature while referencing the existing test files.

@lindapaiste
Copy link
Contributor

If you don't want to rename test files you can change the testRegex setting instead so that it finds the current files. For example, _test\.js will match all index_test.js files.

  • Hi! Oh yes this is a great suggestion. I was thinking that maybe adding the __tests__ directories and moving each of the test files into those dirs might be a nice way of accounting for the test updates? This way we can incrementally chip away at updating tests for each feature while referencing the existing test files.

It might be that we don’t need any major rewrites in order to run with Jest. I am getting there with #1306 but there’s still a few remaining errors. I can probably work on it more this weekend. Most of the tests are passing already and a few are failing due to legitimate issues (as in, they should be failing now too).

@joeyklee joeyklee marked this pull request as ready for review April 5, 2022 21:43
@joeyklee
Copy link
Contributor Author

joeyklee commented Apr 5, 2022

Merging this one in now! The testing update fun begins! 🙈 😂

@joeyklee joeyklee merged commit 7027dba into main Apr 5, 2022
@joeyklee joeyklee deleted the joeyklee.637-rm-other-testing-libs branch April 5, 2022 21:45
joeyklee added a commit that referenced this pull request Apr 6, 2022
…ting-libs"

This reverts commit 7027dba, reversing
changes made to 381df64.
joeyklee added a commit that referenced this pull request Apr 6, 2022
…ting-libs"

This reverts commit 7027dba, reversing
changes made to 381df64.
@joeyklee joeyklee mentioned this pull request Apr 6, 2022
joeyklee added a commit that referenced this pull request Apr 6, 2022
…ting-libs"

This reverts commit 7027dba, reversing
changes made to 381df64.
joeyklee added a commit that referenced this pull request Apr 6, 2022
…ting-libs"

This reverts commit 7027dba, reversing
changes made to 381df64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SEMVER/minor a version tag for a minor release change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants