Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: callCallback should reject the returned Promise #1307

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Bug fix: callCallback should reject the returned Promise #1307

merged 2 commits into from
Mar 7, 2022

Conversation

lindapaiste
Copy link
Contributor

This is step 1 towards fixing the bug described in detail in #1193.

Step 2 will be to find and remove catch clauses inside the individual model classes (or modify them to throw a new error).

@joeyklee joeyklee self-requested a review March 4, 2022 01:19
@joeyklee joeyklee added SEMVER/patch a version tag for a patch release change bug labels Mar 4, 2022
@joeyklee joeyklee mentioned this pull request Mar 4, 2022
Merged
joeyklee
joeyklee approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I really appreciate your excellent work here and the detailed explanation and detective you've provided #1193

I've opened a PR with some tests for this utility in #1315

Let me know if this is ready to go and I'll merge in! Thank you!

@joeyklee joeyklee merged commit af1e447 into ml5js:main Mar 7, 2022
@lindapaiste lindapaiste mentioned this pull request Apr 20, 2022
Open
@lindapaiste lindapaiste self-assigned this Apr 20, 2022
@lindapaiste lindapaiste deleted the fix/callback-rejection branch May 9, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyklee joeyklee joeyklee approved these changes

Assignees

@lindapaiste lindapaiste

Labels
bug SEMVER/patch a version tag for a patch release change
Projects
Descriptive Error Handling
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindapaiste @joeyklee