Code clean-up: Video class. #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `typeof HTMLVideoElement !== 'undefined'` check to prevent errors in Node.js environments. * Reject `loadVideo` promise if there is no video. * Check that `this.size` is a non-zero number before using it. * Set `this.videoReady` to `true` from the base class.
joeyklee
reviewed
Mar 4, 2022
| return new Promise((resolve, reject) => { | ||
| if (!this.videoElt) { | ||
| reject(new Error('No video was passed to the constructor.')); | ||
| } |
There was a problem hiding this comment.
Positive affirmation:
- nice error catching up here! TY! 🙌
joeyklee
reviewed
Mar 4, 2022
| this.video.autoplay = true; | ||
| this.video.playsinline = true; | ||
| this.video.muted = true; | ||
| const playPromise = this.video.play(); | ||
| if (playPromise !== undefined) { | ||
| playPromise.then(() => { | ||
| this.videoReady = true; |
There was a problem hiding this comment.
Positive affirmation:
- nice one! This is def the right place to update the
this.videoReadyflag. 👍
joeyklee
approved these changes
Mar 4, 2022
|
I will merge this in -- the only models currently using this is StyleTransfer. Currently as far as I can tell the style transfer demos are broken, but this doesn't seem to be related to these changes 🙈 |
|
@all-contributors please add @lindapaiste for code ideas bug |
|
I've put up a pull request to add @lindapaiste! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor code clean-up 🧹 No changes to logic.
Videoclass.typeof HTMLVideoElement !== 'undefined'check to prevent errors in Node.js environments.loadVideopromise if there is no video.this.sizeis a non-zero number before using it.this.videoReadytotruefrom the base class.