Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non existing example links from dcgan.md #1358

Merged
merged 2 commits into from
Apr 23, 2022

Conversation

adrianfiedler
Copy link
Contributor

The links to the "LatentVector" example do not exist. Only "RandomWalk", "Slider" and "Random".

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

→ Step 1: Describe your Pull Request 📝

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?
The links to the "LatentVector" example do not exist. Only "RandomWalk", "Slider" and "Random".
So I removed them.

A great PR 🌟🌟

→ Step 2: Share a Relevant Example 🦄

Here's some example code or a demonstration of my feature as a part of this pull request, a separate pull request, in the https://editor.p5js.org, or codepen/jsfiddle/etc...

The best PR 🌟🌟🌟

→ Step 3: Screenshots or Relevant Documentation 🖼

Here's some helpful screenshots and/or documentation of the new feature

The links to the "LatentVector" example do not exist. Only "RandomWalk", "Slider" and "Random".
Copy link
Contributor

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes! It looks like we don't have plain javascript versions of the two LatentVector_ examples either.

Delete non existing plain js examples
@lindapaiste lindapaiste merged commit 585596b into ml5js:main Apr 23, 2022
@lindapaiste
Copy link
Contributor

@all-contributors please add @adrianfiedler for docs

@allcontributors
Copy link
Contributor

@lindapaiste

I've put up a pull request to add @adrianfiedler! 🎉

@lindapaiste lindapaiste added the SEMVER/patch a version tag for a patch release change label Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SEMVER/patch a version tag for a patch release change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants