Rewrite XHR code using Axios #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyklee
approved these changes
Apr 25, 2022
lindapaiste
commented
Apr 25, 2022
| this.labels = val.labels; | ||
| const [modelPathPrefix] = modelPath.split('manifest.json'); | ||
| axios.get(modelPath).then(({ data }) => { | ||
| this.ready = callCallback(this.loadCVAEModel(modelPathPrefix + data.model), callback); |
There was a problem hiding this comment.
I kept the structure here the same as it was before in terms of "fetch then callCallback". But now that I'm looking over it, the API call really should be moved inside of callCallback to get proper error handling. Probably something for a future PR. I've done a bunch of IIFEs in other places for things like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old and verbose
XMLHttpRequestcode and replace withaxiosin: