Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want any model which accepts an image input to also accept a 3D tensor of image pixels. This means that we should not call
tf.browser.fromPixels
directly with the input as it will be an error if called with a tensor. I am instead calling a new utilitytoTensor
which is a simple wrapper aroundtf.browser.fromPixels
that will first check if the input is already a tensor and just return it.Change
tf.browser.fromPixels
totoTensor
in:There are chunks of logic in
Darknet
andDoodlenet
for checking if the image is a tensor and conditionally converting it. These can be deleted entirely because theImageClassifier
handles converting the input to a tensor before calling the specific model'sclassify()
function.Two other minor changes:
await this.ready
andawait mediaReady
should be awaited in parallel rather than sequentially so I changed that in a few places.imgToTensor
function, which rescales and crops in addition to converting, should use127.5
as the divisor rather than127
.