Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing parts of pose by part name #293

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Conversation

mayaman
Copy link
Contributor

@mayaman mayaman commented Feb 21, 2019

Added function so you can do things like pose.nose.x and pose.nose.confidence!

@joeyklee
Copy link
Contributor

@mayaman - Thanks so much for this PR! I didn't get a chance to look at this yet, but I'm very much looking forward to having a look. In the meantime, if you can, it would be wonderful if you could submit a PR to ml5-examples referencing this #293 with a small example showcasing this awesomeness ✨.

The plan is to bake this into the process of submitting new features -- on the todo list! Thanks again! 🙏

@joeyklee
Copy link
Contributor

joeyklee commented Mar 8, 2019

@mayaman hi! Just FYI, I'm working on making a small example to accompany your PR. I will try to get this done in the next couple hours :) Much looking forward to trying it out!

@joeyklee
Copy link
Contributor

joeyklee commented Mar 8, 2019

@mayaman - in a weird git/github PR merge hiccup, I seemed to have merged in your changes into another branch with this PR not being resolved, but the changes being merged in here: 2f67861

As the changes are merged in now, I'm going to close this. I hope this is ok. Sorry about messing this up. The contribution is super. There's also now an example here: ml5js/ml5-examples#96

UPDATE: I'm reopening this and attempting to merge in your changes because I really believe your changes should be the changes that are included in the code base. Maybe it's silly, but I think it is important that you get proper credits for the work. The travis test should run and pass + then everything will be all good. Fingers crossed!

@joeyklee joeyklee closed this Mar 8, 2019
@joeyklee joeyklee reopened this Mar 8, 2019
@joeyklee joeyklee merged commit 7d7600e into ml5js:master Mar 8, 2019
@mayaman
Copy link
Contributor Author

mayaman commented Mar 11, 2019

oh amazing, thank you! this is really great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants