Made it possible to choose the filename when saving a featureExtractor model #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a custom filename to the model that is saved.
|
@jepster-dk - wow! this is great + thank you for your contribution. As I'm making my way through PRs, I'll be sure to let you know when we're ready to merge. Thanks again! |
|
@jepster-dk - Just tested! very cool. I will plan to make an example that takes a simple javascript prompt() that allows people to add in a name :) Merging now! Thanks so much 🙏! |
|
@all-contributors please add @jepster-dk for code ideas |
|
I've put up a pull request to add @jepster-dk! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Adds custom filename functionality to MobileNet.js' save() function.
Related to issue #352.
Relevant Example or Paired Pull Request to ml5-examples 🦄
When calling MobileNet.js' save() function, you can now add another parameter, if you wish to choose the name of the file that is saved.
E.g.
save(callback, 'myBeautifulModel')orsave(callback, 'anotherGreatModel)