Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix single quote typo in nn reference #679

Merged
merged 1 commit into from
Nov 5, 2019
Merged

fix single quote typo in nn reference #679

merged 1 commit into from
Nov 5, 2019

Conversation

vndrewlee
Copy link
Contributor

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

Branch

Release

Description

Correcting small typos where a backquote was mistakenly used to close a single quoted string.

example mistake, note the final character:

'regression`

example fix:

'regression'

@joeyklee joeyklee changed the base branch from release to gh-pages November 5, 2019 17:22
@joeyklee joeyklee changed the base branch from gh-pages to development November 5, 2019 17:23
@joeyklee joeyklee changed the base branch from development to release November 5, 2019 17:23
@joeyklee
Copy link
Contributor

joeyklee commented Nov 5, 2019

Thanks @vndrewlee ! Once the tests pass, I will merge this in. Thanks for catching this!

@joeyklee joeyklee merged commit f143239 into ml5js:release Nov 5, 2019
@joeyklee joeyklee mentioned this pull request Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vndrewlee @joeyklee