Remove manual fetching of NN model.json
and weights.bin
files and use tf.io.http
instead
#114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #113
Ref #84 (comment)
Changes:
axios.get
and conversion toFile
objects.tf.io.browserFiles
totf.io.http
.weightUrlConverter
option to use the path from the user's object instead of the path that TFJS finds inweightsManifest
section of themodel.json
file.Note:
weightUrlConverter
is specified as anasync
function but I wrote it as a normal function. We can throw in anasync
keyword if there is concern.I did try it out and it worked.
I even modified the path in the
model.json
file (to"paths":["./not-the-right-path/model.weights.bin"]
) because in this example the override URL is the same as what's in theweightsManifest
. We do this in order to support the p5.js Web Editor, where the actual file path is a remote Amazon S3 URL.