Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix body pose bugs #174

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Fix body pose bugs #174

merged 4 commits into from
Jul 19, 2024

Conversation

ziyuan-linn
Copy link
Member

This PR fixes various bugs in the bodyPose model.

  • Rename the confidence value for the entire pose from score to confidence.
  • Fix the flipped and flipHorizontal not working issue by implementing mirroring on ml5's end.
  • Fix the keypoints not resizing issue on MoveNet model.
    • It seems like MoveNet model's keypoints are scaled on the video's intrinsic size ("videoWidth" and "videoHeight") instead of display size ("width" and "height"). This contradicts the behavior of handPose, faceMesh, and the BlazePose model. This fix rescales the keypoints to the video display size.

@shiffman
Copy link
Member

Looks great! This change might be worth doing a patch release to practice and develop a process for documenting releases? cc @sharellb @alanvww

@shiffman shiffman merged commit 542e5a5 into main Jul 19, 2024
@ziyuan-linn ziyuan-linn deleted the fix-bodyPose-bugs branch September 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants