Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix json parse bug in neuralNetworkData loadData #207

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix json parse bug in neuralNetworkData loadData #207

merged 1 commit into from
Sep 30, 2024

Conversation

ziyuan-linn
Copy link
Member

This PR fixes the bug in #206.

Changes:

  • Run formatted on NeuralNetwork
  • Fix the bug where JSON.stringify was necessarily called
  • Update the console message for readability

@ziyuan-linn ziyuan-linn linked an issue Sep 23, 2024 that may be closed by this pull request
nn.loadData() appears to be broken #206
Closed
@shiffman
Copy link
Member

Thank you for this @ziyuan-linn! I think an older version of ml5.js supported csv data as well? So that is something we could consider for the future. But I don't think it's a priority. If anyone feels it's a need or is excited to work on it, we can open an issue.

@shiffman shiffman merged commit e6daeee into main Sep 30, 2024
@ziyuan-linn ziyuan-linn deleted the neuralNetwork-loadData-fix branch October 11, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nn.loadData() appears to be broken
2 participants
@ziyuan-linn @shiffman