add getConnections and getUVCoords functions #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyuan-linn
force-pushed
the
FaceMesh-connections-and-uv
branch
from
f61cab7 to
2c13320
Compare
Co-Authored-By: Daniel Shiffman <[email protected]>
ziyuan-linn
force-pushed
the
FaceMesh-connections-and-uv
branch
from
2c13320 to
5ef20ca
Compare
|
This is awesome, thank you!!! I'll leave open for any further discussion and merge tomorrow before I record my video. I'll use my own ml5.js build for the recording session and then we can work on publishing a new release later this week. (The video wouldn't come out for some time still.) |
shiffman
reviewed
Oct 21, 2024
examples/faceMesh-uv-map/sketch.js
Outdated
| let a = face.keypoints[indexA]; | ||
| let b = face.keypoints[indexB]; | ||
| let c = face.keypoints[indexC]; | ||
| const uvA = { x: 1 - uvCoords[indexA][0], y: uvCoords[indexA][1] }; |
There was a problem hiding this comment.
Might not need the 1 - here I was messing around with inverting the x.
|
Merging! I am recording a video tutorial about this now! I will build a version of the library and if I encounter any issues I will make updates in a new branch. After I finish the session, we can prepare a new release! (If anyone wants to tune into the session send me an email or DM on Discord!) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
faceMesh.getConnectionsandfaceMesh.getUVCoordsfunctions.See detail in #211.