Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder emphasised #182

Closed
wants to merge 1 commit into from
Closed

Fix folder emphasised #182

wants to merge 1 commit into from

Conversation

MoPaMo
Copy link

@MoPaMo MoPaMo commented May 15, 2021

For some reason, markdown doesn’t render /text as bold so the folders aren’t rendered*.
Instead, I put the slash behind the name of the folder

What kind of change does this PR introduce?
Fixing a bug in Markdown

Does this PR introduce a breaking change?
Definitely not 🙃

What needs to be documented once your changes are merged?

Edit:
*I just realised GitHub renders them right, nevertheless the Docs don’t:
70E44740-0B2C-4E0C-A9CC-E1A7B26E1BDD

https://learn.ml5js.org/#/tutorials/hello-ml5

For some reason, markdown doesn’t render **/text** as bold so the folders aren’t rendered. 
Instead, I put the slash behind the name of the folder
Copy link
Member

@bomanimc bomanimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Thank you!

@bomanimc
Copy link
Member

Oops! I almost didn't notice which repo this was.

Though we have a docs folder in this repository, our documentation is actually deployed from the ml5-library repository. Would you mind opening this PR there?

We should also delete the docs folder in this repository to reduce confusion! I opened #183 for this.

@bomanimc
Copy link
Member

Closing this PR to prefer ml5js/ml5-library#1206!

@bomanimc bomanimc closed this May 16, 2021
@MoPaMo MoPaMo deleted the patch-1 branch May 16, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants