-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the country states/regions #40
Comments
I've been thinking about this and I have mixed feelings because it will take us away from the goal of this project, which is to provide top-level data about world countries. What do you think? Is there really a need for this? |
My biggest concern with the addition of the states is that the file will become very large. What about having separate files for each country with additional details such as its states? |
FYI: You can get states (regions) for countries at the openmundi/world.db site. All data is public domain use as you please. Cheers. |
That is my concern too. I agree to use separate files. @geraldb thank you for the link. |
I would like to contribute on this, if we separate the files, what structure are we looking for and shall we use cca2 or cca3 for naming the files? What about the folder structure? Here's few ideas:
I have a preference for /data/[cc].regions.json, what do you think? We need also to be careful on how to name this... it's a bit tricky. The definition and hierarchy changes from one place to the other (states / provinces / counties / municipalities / parishes / districts / regions) Canada: Italy: New-Zealand: United-States: |
I propose to use Regarding the name pattern, I prefer to use Thank you for your initiative, your contributions are very welcome! |
What do you think about the format in the following examples for France region of Île-de-France and Canada for Québec) This schema would allow two levels of regional information and could be very easily expended into providing population data, languages, and more for each level of regions. Very glad to contribute :) /data/can.json
/data/fra.json
|
…a` folder (see comment #40 (comment))
The example is good! Can you please use lowercase strings for |
@wiredmax Hi, have you had any time to continue on this? Is there anything I can do to help? |
I'm quite busy with a lot of stuff at work, but it's still a need we have in many projects. @msabeh works with me and she should be available to expend this further in early january. She has already done a great job rencently with: https://github.com/wiredmax/world-currencies |
So how can we wrap-up this proposal and get on working? :) |
@wiredmax any updates on this one? If you don't have time to finish this, it's not a problem, someone can take over. |
@msabeh and I will start working on this. Starting today, we will fork it and structure the data this way if you still agree: The only only change with the previously disccussed in this issue is the lower case type.
We'll start with the easy ones (from our perspective) North America and Europe, than South and Central America, Africa (starting with Magreb and Northern africa) then moving to Middle-East and Asia and then finish with all the special cases. |
@wiredmax I'm glad to hear that you are working on this. I still agree with the format. I think that we should use the same format for the "name": {
"common": "Quebec",
"native": {
"fra": {
"common": "Québec"
}
}
} It's a bit verbose, but it's coherent with the data in What do you think? |
@mathieumg Yes they are double quoted since it's reglular JSON and not JSON5. |
@mledoze For the name I agree to, but shall we do it only at the first level or both? Doing it on both level seems a bit heavy for me since to me the native name is the one always used.
vs
|
@wiredmax yes doint it on both levels is too heavy. This solution {
"name": {
"common": "Alberta",
"native": {
"eng": {
"common": "Alberta"
}
},
"type": "province",
"divisions": [
{ "type": "district", "name": "Acadia" },
{ "type": "district", "name": "Athabasca" }, is better 👍 |
But you keep using single quotes in your examples. 😉 |
All good then @msabeh will start working on the fork, starting with North America, once done I'll submit a PR that we could merge in a regions branch onto your project and see if there's needed ajustements and then continue further with Europe. Once all the regions of the word are 98% (2% we are talking about the weird case we will probably find) you could then merge onto master. @mathieumg I know, I didn't notice them, I've fixed it in my last comment, no worries. Anyway @msabeh atom will notice her of single quotes. |
Yay! I'll be working on this this afternoon, I'll keep you guys posted. |
Hi all, thanks for the job all of you guys have been done. I'd like to ask there is a considerable progress about this issue? |
@justqyx hello, unfortunately I think this PR is dead, would you like to work on it? |
I'll close this issue for the moment. If someone want to work on it, feel free to open a new issue. |
Bookmarking this as a reminder to myself because i might be able to help. @adrienne |
@adrienne your help is welcome! 🙂 |
The idea is to add the country states or regions (depending on the country).
A format was proposed here: #6 (comment)
@shanti2530 suggets to import the data from: http://vikku.info/programming/geodata/geonames-get-country-state-city-hierarchy.htm
I propose not to add cities because it would make the dataset too big in my opinion. I prefer to focus on top-level data.
The text was updated successfully, but these errors were encountered: