Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UN member states boolean flag #401

Merged
merged 4 commits into from
Jul 19, 2020
Merged

UN member states boolean flag #401

merged 4 commits into from
Jul 19, 2020

Conversation

rkorzeniec
Copy link
Contributor

@rkorzeniec rkorzeniec commented Jun 29, 2020

Added unMember boolean flag.
Currently there are 193 (according to wikipedia + un offcial website, this leaves the other 57 states having the flag set to false

@rkorzeniec
Copy link
Contributor Author

@mledoze friendly ping 😉

@mledoze
Copy link
Owner

mledoze commented Jul 15, 2020

Hello @rkorzeniec, I'm sorry for the delay, you know life, the quarantine and everything else...

I'll look into your pull request this week. Thank you for your work!

Meanwhile could you please add en entry in the changelog?

@mledoze
Copy link
Owner

mledoze commented Jul 18, 2020

The PR looks good. I just need the entry in the changelog before merging it.

@rkorzeniec
Copy link
Contributor Author

@mledoze I totally understand, I was just worried that you abandoned it a bit, sine the other PRs haven't got much attention either in some time.
I will go right ahead with the changelog. Would you like me to add it to unreleased section or create 4.1.0 section?

@rkorzeniec
Copy link
Contributor Author

I added it to unreleased section for the time being. Much appreciated.

@mledoze mledoze merged commit da8b097 into mledoze:master Jul 19, 2020
@mledoze
Copy link
Owner

mledoze commented Jul 19, 2020

It's merged, thank you for your work.

@rkorzeniec
Copy link
Contributor Author

you're welcome 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants