Fixing US and Canadian IDD suffixes. #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinheidegger
changed the title
Following the Wikipedia list on North American IDD number codes [1], this adds all canadian province codes that were previously missing. Also I noticed that some of the US idd codes were missing. Most interestingly 710 - us government, but also all PCS [2] numbers besides some other numbers where the reason for its prior absence is unclear. [1]: https://en.wikipedia.org/wiki/List_of_North_American_Numbering_Plan_area_codes#Area_codes_by_state,_province_or_country [2]: https://en.wikipedia.org/wiki/Personal_communications_service_(NANP)
martinheidegger
force-pushed
the
fix-us-ca-idd
branch
from
8b52d19
to
2e57daf
Compare
|
Hi, thank you for this update. Could you please resolve the merge conflicts on |
|
@mledoze done |
|
Thank you @martinheidegger |
|
Thank you as well! Awesome work. When do you see a 4.2 release happening? |
martinheidegger
added a commit
to tradle/models
that referenced
this pull request
Dec 28, 2021
ping @mledoze |
I will release it today. Sorry for the delay. |
|
Awesome 👍 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Canada had an suspiciously empty IDD suffix list. With a quick check there indeed seems to exist IDD codes for Canada. 😉
Following the Wikipedia list on North American IDD number codes, this PR adds all canadian province codes that were previously missing. Also, I noticed that some of the US IDD codes were missing. Most interestingly 710 - us government, but also all PCS numbers besides some other numbers where the reason for its prior absence is unclear.
Sorry: Composer is still not working on my computer