Change to using published solrcloud gem #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… old collections to keep.
niquerio
reviewed
Dec 1, 2023
lib/authority_browse/solr.rb
Outdated
| # @return [Array] Array of old authority browse Solrcloud collection | ||
| # strings | ||
| def self.list_old_collections(list = S.solrcloud.collections) | ||
| def self.list_old_collections(list = S.solrcloud.collections, keep: 3) |
niquerio
requested changes
Dec 1, 2023
lib/authority_browse/solr.rb
Outdated
| collections: [collection_name] | ||
| } | ||
| ) | ||
| S.solrcloud.create_alias(name: reindex_alias, collection_name: collection_name) |
There was a problem hiding this comment.
This and set_production_alias needs force
|
Re: |
|
I'm actually going to add date/timestamp stuff to the SolrCloud::Connection gem and then we can use that. |
niquerio
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor changes:
list_old_collectionsto specify how many you want to keep and wrote a test for itTwo questions:
Was there a reason for that?
out in the same order). Makes we wonder if we should use YYYY-mm-dd-hhmmss and find everything before
nowexcept the last N (i.e., turnnowinto aYYYY-mm-dd-hhmmssstring and use that for the comparison).