Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParallelSGD omp fix #135

Merged
merged 4 commits into from
Sep 26, 2019
Merged

ParallelSGD omp fix #135

merged 4 commits into from
Sep 26, 2019

Conversation

zoq
Copy link
Member

@zoq zoq commented Sep 14, 2019

@zoq zoq mentioned this pull request Sep 16, 2019
Closed
@zoq
Copy link
Member Author

zoq commented Sep 24, 2019

@coatless have seen your message in IRC, do you see a similar issue as described in #132?

@coatless
Copy link
Contributor

@zoq we're running a different set of checks than the official tests. So #132 didn't pop up.

@zoq
Copy link
Member Author

zoq commented Sep 24, 2019

I see, thanks for the clarification.

@rcurtin
Copy link
Member

rcurtin commented Sep 25, 2019

@mlpack-jenkins test this please

rcurtin
rcurtin approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; if you want to update HISTORY.md feel free, otherwise I will do it during merge (while I make a release).

mlpack-bot[bot]
mlpack-bot bot approved these changes Sep 26, 2019
View reviewed changes
Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@zoq zoq merged commit d15772b into mlpack:master Sep 26, 2019
@zoq
Copy link
Member Author

zoq commented Sep 26, 2019

Let's start the matrix build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlpack-bot mlpack-bot[bot] mlpack-bot[bot] approved these changes

@rcurtin rcurtin rcurtin approved these changes

Assignees
No one assigned
Labels
c: tests s: needs review t: bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoq @coatless @rcurtin