Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example doc fix + add/use default argument. #174

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Conversation

zoq
Copy link
Member

@zoq zoq commented Mar 1, 2020

There are some examples in the documentation that can't be copy/pasted, which is either because we didn't use the correct syntax or because some of the parameters are missing.

@zoq
Copy link
Member Author

zoq commented Mar 1, 2020

The history wasn't modified, intentionally, to see if it works.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches! But shouldn't the build fail because there's no HISTORY update? 😄

I can do a release once this is merged. 👍

@zoq
Copy link
Member Author

zoq commented Mar 2, 2020

Yes it should, @birm is working on it here: #175

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@rcurtin rcurtin merged commit 4fdfc97 into mlpack:master Mar 3, 2020
rcurtin added a commit that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants