Nits on NSGA2

[jonpsy]

Hi @say4n , I've been reading your code on NSGA2 and I really like it :). I've made some small corrections.

• minor grammar fix
• replace std::endl with "\n"

[mlpack-bot]

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

• All code should follow the style guide
• Documentation added for any new functionality
• Tests added for any new functionality
• Tests that are added follow the testing guide
• Headers and license information added to the top of any new code files
• HISTORY.md updated if the changes are big or user-facing
• All CI checks should be passing

Thank you again for your contributions! 👍

[ShikharJ]

Replacing std::endl with \n is a useless change.

[jonpsy]

In hindsight, yes, but I'd rather avoid them if possible. Anycase, these changes are minor nitpicks.

[rcurtin]

Hey @jonpsy, thanks for the comment fix! 👍 mlpack and ensmallen code tend to use std::endl throughout, so we probably ought to stick with that.

Did you have more changes you were planning to make, or is this ready to go? (If you plan on changing more, we can wait until you're done to finish the review process. :))

[zoq]

Nice catch, even if that one is a small fix, I think it's important to have correct and clear comments 👍

[jonpsy]

Thanks for the reviews. The primary goal of this PR was to get acquainted to the reviewing process. I was making the first pass at this code so I caught a few nitpicks which I've posted.I do realize my changes were not substantial.

I've made some more changes, but I'd like your opinions before I make them (more than just grammar fix :) ). Can we do it on a seperate PR? Can we merge this one for the time being?

I'd like this code to be

• Minimize use of for loops
• Write cache-friendly code
• Reduce code length
• Possibly structure it to inherit from abstract class "MultiObjective" so that it gives space to add MOEA/D (my next work)

[jonpsy]

There's also a prospect of parallelizing through OMP.

[zoq]

Thanks for the reviews. The primary goal of this PR was to get acquainted to the reviewing process. I was making the first pass at this code so I caught a few nitpicks which I've posted.I do realize my changes were not substantial.

I've made some more changes, but I'd like your opinions before I make them (more than just grammar fix :) ). Can we do it on a seperate PR? Can we merge this one for the time being?

I'd like this code to be

• Minimize use of for loops
• Write cache-friendly code
• Reduce code length
• Possibly structure it to inherit from abstract class "MultiObjective" so that it gives space to add MOEA/D (my next work)

Let's continue the discussion in #263.

[zoq]

Looks good to me.

[mlpack-bot]

Second approval provided automatically after 24 hours. 👍

[mlpack-bot]

Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in COPYRIGHT.txt and you haven't already, please feel free to push a change to this PR---or, if it gets merged before you can, feel free to open another PR.

In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to [email protected], and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. 👍

[say4n]

Oops, thanks, great catch! :)

[jonpsy]

@say4n, Hi, thanks. I'd love your reviews on the follow-up PR. Cheers! :)

[zoq]

Thanks for the contribution.