Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code analyzer adjustments #284

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Code analyzer adjustments #284

merged 3 commits into from
Apr 9, 2021

Conversation

zoq
Copy link
Member

@zoq zoq commented Apr 7, 2021

Some simple adjustments to make the code analyzer happy.

@zoq
Copy link
Member Author

zoq commented Apr 7, 2021

@mlpack-jenkins test this please

@zoq
Copy link
Member Author

zoq commented Apr 7, 2021

I'm not going to fix the NSGA warnings, because #263 will fix most of the issues. Also once this is merged, I will remove the old static analysis job.

rcurtin
rcurtin approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CMake isn't found on polar and that's why the mlpack master build test job fails, but the changes all look fine to me. 👍

include/ensmallen_bits/fw/proximal/proximal_impl.hpp Show resolved Hide resolved
@zoq
Copy link
Member Author

zoq commented Apr 8, 2021

Looks like CMake isn't found on polar and that's why the mlpack master build test job fails, but the changes all look fine to me. +1

Yeah, I have the Dockerfile (https://github.com/mlpack/jenkins-conf/blob/master/Dockerfiles/jenkins-amd64-debian.Dockerfile) I just have to use it in the build config. But I figured I should ask first before I do the change.

@jonpsy
Copy link
Member

jonpsy commented Apr 9, 2021 •
edited
Loading

I have resolved the warnings for nsga2 in my open PR. Hope to see this merged soon :D!

@zoq
Copy link
Member Author

zoq commented Apr 9, 2021

@mlpack-jenkins test this please

4 similar comments
@zoq
Copy link
Member Author

zoq commented Apr 9, 2021

@mlpack-jenkins test this please

@zoq
Copy link
Member Author

zoq commented Apr 9, 2021

@mlpack-jenkins test this please

@zoq
Copy link
Member Author

zoq commented Apr 9, 2021

@mlpack-jenkins test this please

@zoq
Copy link
Member Author

zoq commented Apr 9, 2021

@mlpack-jenkins test this please

mlpack-bot[bot]
mlpack-bot bot approved these changes Apr 9, 2021
View reviewed changes
Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@zoq zoq merged commit 388bcd8 into mlpack:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin approved these changes

@mlpack-bot mlpack-bot[bot] mlpack-bot[bot] approved these changes

Assignees
No one assigned
Labels
c: optimizers c: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoq @jonpsy @rcurtin