Created for review #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: complete header
Feature/links
merge feature/hello-there
…le and pull fixes
Feature/about
feat: added ability for multiple carousels and not just one
trigger rebuild
update path in package.json
fix relative path
fix:remove publicpath from webpack
poalrom
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
You did a great job! I really appreciated that you finish that project when you have too much work in the last sprints.
There are little issues to fix about image placing and one bug. Users should not can to submit the pledge form multiple times.
And we have some text issues from the NGO. Can you please fix it?
https://yadi.sk/i/95AnztsDpf_XtQ
| } | ||
|
|
||
| .additional-info__link:hover .arrow-icon { | ||
| background: url('../../arrow-icon/yellow-arrow.svg') center right no-repeat; |
There was a problem hiding this comment.
It's better to make arrow-icon as an element of additional-info block because blocks should not depend on another block
| @@ -0,0 +1,23 @@ | |||
| .carousel__slide-button_type_next { | |||
| background-image: url(../../../../images/right-arrow.svg); | |||
There was a problem hiding this comment.
Move this image to the modifier folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.