Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropdown menu #48

Merged
merged 3 commits into from
Jul 28, 2020
Merged

dropdown menu #48

merged 3 commits into from
Jul 28, 2020

Conversation

julieg18
Copy link
Collaborator

No description provided.

@julieg18 julieg18 requested review from mm1123452, tantany and Av1sa July 28, 2020 17:52
@julieg18 julieg18 self-assigned this Jul 28, 2020
tantany
tantany requested changes Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@tantany tantany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

  1. I feel like the menu should slide from right to left and glide just a little bit slower.
  2. The dropdown menu was active when I changed the screen size to mobile screen, even though I didn't push the menu button.

tantany
tantany approved these changes Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@tantany tantany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@julieg18 julieg18 merged commit 23342c7 into develop Jul 28, 2020
@julieg18 julieg18 deleted the feature/dropdown-menu branch July 28, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantany tantany tantany approved these changes

@mm1123452 mm1123452 Awaiting requested review from mm1123452

@Av1sa Av1sa Awaiting requested review from Av1sa

Assignees

@julieg18 julieg18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julieg18 @tantany