Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-workspaces to return OS specific paths #8

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

kthompson
Copy link
Contributor

Due to an error in how node-glob returns paths, a specific option is
required in order to return paths appropriately for each platform.

See: isaacs/node-glob#419
Fixes: mmazzarolo/react-native-universal-monorepo#12

Due to an error in how node-glob returns paths, a specific option is 
required in order to return paths appropriately for each platform.

See: isaacs/node-glob#419
Fixes: mmazzarolo/react-native-universal-monorepo#12
Copy link
Owner

@mmazzarolo mmazzarolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kthompson, looks good to me (TIL!)

@mmazzarolo mmazzarolo merged commit 714fd0c into mmazzarolo:master Nov 7, 2021
@mmazzarolo mmazzarolo mentioned this pull request Nov 7, 2021
github-actions bot pushed a commit that referenced this pull request Nov 7, 2021
## [1.1.2](v1.1.1...v1.1.2) (2021-11-07)

### Bug Fixes

* Update get-workspaces to return OS specific paths ([#8](#8)) ([714fd0c](714fd0c))
@github-actions
Copy link

github-actions bot commented Nov 7, 2021

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack error on Windows
2 participants